Skip to content

OCPBUGS-121385: Resolve Additional Storage agnhost image through mirror - #31618

Open
redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:reliability/ocpbugs-121385-mirrored-agnhost
Open

OCPBUGS-121385: Resolve Additional Storage agnhost image through mirror#31618
redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:reliability/ocpbugs-121385-mirrored-agnhost

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

This pull request was generated by the Product Reliability Agent. To help us improve product stability and CI, please focus review on functional correctness and material concerns. The agent will automatically address feedback, but we’d appreciate keeping non-blocking nits from delaying an otherwise correct PR. Within two business days, please merge, provide blocking feedback, or close the PR with a reason.

Summary

The Additional Storage end-to-end test now resolves the agnhost image through the existing image.LocationFor mapping and reuses the resolved pull spec for image-store prepopulation, image verification/removal, and both pod specifications. This keeps PullNever aligned with the pre-populated image while preventing the test from using an unmirrored upstream runtime image.

Validation

  • gofmt -d test/extended/node/additional_storage_e2e.go
  • go test ./test/extended/node
  • git diff --check upstream/main

Tracking

OCPBUGS-121385

AI-generated. Review for accuracy.

@stbenjam requested in Slack thread

Summary by CodeRabbit

  • Tests
    • Improved storage-related end-to-end test validation for image pulling, lookup, and removal.
    • Test failures now report clearer error messages instead of being silently ignored.
    • Pod creation and readiness checks now propagate failures more reliably, improving test result accuracy.

@redhat-chai-bot
OCPBUGS-121385: Resolve Additional Storage image through mirror
85cd9ff 
Signed-off-by: Chai Bot <chai-bot@redhat.com>
@openshift-merge-bot

openshift-merge-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Sep 7, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 7, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 7, 2026

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-121385, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This pull request was generated by the Product Reliability Agent. To help us improve product stability and CI, please focus review on functional correctness and material concerns. The agent will automatically address feedback, but we’d appreciate keeping non-blocking nits from delaying an otherwise correct PR. Within two business days, please merge, provide blocking feedback, or close the PR with a reason.

Summary

The Additional Storage end-to-end test now resolves the agnhost image through the existing image.LocationFor mapping and reuses the resolved pull spec for image-store prepopulation, image verification/removal, and both pod specifications. This keeps PullNever aligned with the pre-populated image while preventing the test from using an unmirrored upstream runtime image.

Validation

  • gofmt -d test/extended/node/additional_storage_e2e.go
  • go test ./test/extended/node
  • git diff --check upstream/main

Tracking

OCPBUGS-121385

AI-generated. Review for accuracy.

@stbenjam requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 7, 2026
@redhat-chai-bot

redhat-chai-bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

/label reliability

AI-generated. Review for accuracy.

@redhat-chai-bot

redhat-chai-bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

🗣️ We’d really appreciate your feedback here

AI-generated. Review for accuracy.

@openshift-ci openshift-ci Bot added the reliability Categorizes an issue as related to the Product Reliability Agent. label Sep 7, 2026
@openshift-ci

openshift-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign haircommander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: 8c13e6ab-690a-4964-93b5-cbec8c2eb008

📥 Commits

Reviewing files that changed from the base of the PR and between 85cd9ff and 9153558.

📒 Files selected for processing (1)
  • test/extended/node/additional_storage_e2e.go

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.

Walkthrough

The additional storage end-to-end test now uses explicit assertions for image operations and pod startup. It also centralizes pod creation and readiness checks and simplifies registry-pull logging.

Changes

Additional storage test validation

Layer / File(s) Summary
Image lifecycle checks
test/extended/node/additional_storage_e2e.go		 The test resolves the image location and adds failure messages for image pull, lookup, and removal operations.
Pod startup validation
test/extended/node/additional_storage_e2e.go		 A local helper now asserts pod creation and Running readiness. The test uses it for both startup paths and simplifies successful registry-pull logging.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 91535

The additional-storage test consistently uses the resolved mirrored image reference and now reports image and pod startup failures explicitly. No merge-blocking risk is identified.

Suggested reviewers: bhargavigudi

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: resolving the Additional Storage agnhost image through the image mirror.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The PR changes only test/extended/node/additional_storage_e2e.go and does not add or modify a Ginkgo test title. The existing Describe and It titles are static string literals. They contai…
Test Structure And Quality ✅ Passed PASS. The PR does not introduce a custom-check failure. The existing single It block already covered storage configuration and image behavior before this PR. The PR only changes image resolution, as…
Microshift Test Compatibility ✅ Passed PASS: The pull request does not add a new Ginkgo test. It modifies the existing test, which is wrapped in a Describe tagged with [apigroup:config.openshift.io] and `[apigroup:machineconfiguration.…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS. The PR modifies the existing Additional Storage test; it does not add a new Ginkgo test declaration. The test is already protected by its enclosing BeforeEach: exutil.IsSingleNode(...) check…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only test/extended/node/additional_storage_e2e.go. The diff updates image resolution, assertions, logging, and pod wait handling. It does not add or modify deployment …
Ote Binary Stdout Contract ✅ Passed No OTE stdout contract violation was introduced. The PR changes only test/extended/node/additional_storage_e2e.go. It adds no main, init, TestMain, suite hook, RunSpecs setup, or direct stdout/logging…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The changed test adds no IPv4 addresses, IPv4-only parsing, CIDRs, or URL construction. The image pull now uses image.LocationFor(...), which resolves the approved upstream image to the repository's…
No-Weak-Crypto ✅ Passed PASS: The PR changes only test/extended/node/additional_storage_e2e.go. The added code resolves an image location, checks command errors, and waits for pods. It adds no MD5, SHA1, DES, RC4, 3DES, Bl…
Container-Privileges ✅ Passed PASS. The PR changes only image resolution, assertions, logging, and pod create/wait calls. The created pod sets RunAsUser 1000, RunAsNonRoot true, drops ALL capabilities, and sets AllowPrivilegeEscal…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request does not introduce sensitive-data logging. It removes the resolved image reference from log messages and stops logging the full Kubernetes pull event message. New assertion mess…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot

openshift-ci-robot commented Sep 7, 2026

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-121385, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

This pull request was generated by the Product Reliability Agent. To help us improve product stability and CI, please focus review on functional correctness and material concerns. The agent will automatically address feedback, but we’d appreciate keeping non-blocking nits from delaying an otherwise correct PR. Within two business days, please merge, provide blocking feedback, or close the PR with a reason.

Summary

The Additional Storage end-to-end test now resolves the agnhost image through the existing image.LocationFor mapping and reuses the resolved pull spec for image-store prepopulation, image verification/removal, and both pod specifications. This keeps PullNever aligned with the pre-populated image while preventing the test from using an unmirrored upstream runtime image.

Validation

  • gofmt -d test/extended/node/additional_storage_e2e.go
  • go test ./test/extended/node
  • git diff --check upstream/main

Tracking

OCPBUGS-121385

AI-generated. Review for accuracy.

@stbenjam requested in Slack thread

Summary by CodeRabbit

  • Tests
  • Updated end-to-end testing to resolve the test image according to the environment, improving portability across different setups.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@redhat-chai-bot
OCPBUGS-121385: Redact mirrored image from test logs
9153558 
Signed-off-by: Chai Bot <chai-bot@redhat.com>
@openshift-merge-bot

openshift-merge-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci

openshift-ci Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo
@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

No one assigned

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review reliability Categorizes an issue as related to the Product Reliability Agent.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@redhat-chai-bot @openshift-ci-robot